Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ITs for Java 17 and 21 (#126) #133

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Add ITs for Java 17 and 21 (#126) #133

merged 6 commits into from
Apr 18, 2024

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Apr 16, 2024 •
edited
Loading

  • Create dedicated folders for ITs suits based on Java version. I found this to be much simpler to maintain than a single folder with different intertwine configurations.

Closes #126

@abelsromero abelsromero marked this pull request as draft April 16, 2024 21:23
@abelsromero
Copy link
Member Author

Currently this PR is a proof of concept.

TODO:

  • Update validations for Java 17.
  • Review "opens"
  • Add Java 21 tests

@abelsromero abelsromero marked this pull request as ready for review April 18, 2024 06:50
@abelsromero abelsromero force-pushed the issue-126/main/add-its-for-java-17-and-21 branch from 2bbc1d3 to 9c8022e Compare April 18, 2024 09:37
@abelsromero abelsromero merged commit 144704b into asciidoctor:main Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Integration tests (aka. with maven-invoker-plugin) to test Java 17 and 21
1 participant
@abelsromero